[tor-bugs] #30342 [Core Tor/Tor]: 9 dephects on prob_distr.c (April 2019)

[Tor Bug Tracker & Wiki]

#30342: 9 dephects on prob_distr.c (April 2019)
---------------------------------+------------------------------------
 Reporter:  asn                  |          Owner:  (none)
     Type:  defect               |         Status:  new
 Priority:  Medium               |      Milestone:  Tor: 0.4.1.x-final
Component:  Core Tor/Tor         |        Version:
 Severity:  Normal               |     Resolution:
 Keywords:  prob-distr coverity  |  Actual Points:
Parent ID:                       |         Points:  0.4
 Reviewer:                       |        Sponsor:
---------------------------------+------------------------------------

Comment (by asn):

 Replying to [comment:3 catalyst]:
 > in src/lib/math/prob_distr.h:
 > {{{
 >      53  *  We define this conditionally to suppress false positives
 from
 >      54  *  Coverity, which gets confused by the sizeof business.
 >      55  */
 >      56 #ifdef __COVERITY___
 >      57 #define TYPE_CHECK_OBJ(OPS, OBJ, TYPE) 0
 > }}}
 > There seems to be an extra underscore at the end of `__COVERITY___`. I
 think all other occurrences end with two underscores, not three.

 Yes, you are right. Indeed, coverity seems to have a revision of the
 codebase with 3 underscores, but that's not the case in master (since
 `48a574604bef`):
 https://github.com/torproject/tor/blob/master/src/lib/math/prob_distr.h#L56

 CID `1444641` was also fixed in #30180 and yet it still appears in the web
 interface.

 Finally, wrt CID `1415723` (mentioned in the comment above), the CID does
 not appear in the web interface anymore (but i did receive it in an email
 on the 30th of April). The assert I was refering to is
 https://github.com/torproject/tor/blob/master/src/feature/client/circpathbias.c#L189

 tl;dr coverity has a dated version of our codebase, and also sends emails
 about fixed issues. Not sure what we could do here, since I dont see a
 button that pulls the latest git rev.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30342#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online