[tor-bugs] #25688 [Obfuscation/Snowflake]: proxy-go is still deadlocking occasionally

[Tor Bug Tracker & Wiki]

#25688: proxy-go is still deadlocking occasionally
--------------------------------------------+------------------------------
 Reporter:  dcf                             |          Owner:  cohosh
     Type:  defect                          |         Status:
                                            |  needs_revision
 Priority:  Low                             |      Milestone:
Component:  Obfuscation/Snowflake           |        Version:
 Severity:  Normal                          |     Resolution:
 Keywords:  network-team-roadmap-2019-Q1Q2  |  Actual Points:
Parent ID:                                  |         Points:  3
 Reviewer:                                  |        Sponsor:
--------------------------------------------+------------------------------

Comment (by arlolra):

 > This error appears to occur *after* OnIceComplete() is fired, meaning
 that in the proxy-go code:

 Ah, so it is a bug in go-webrtc to assume `iceComplete`, when only
 `iceGathering` has completed,
 https://github.com/keroserene/go-
 webrtc/blob/master/peerconnection.go#L518-L522

 > It's also worth pointing out that apparently OnICECompletel is being
 deprecated (​peerconnection.go#L518) we are better off not relying on it
 anyway.

 If that's the case, we should remove it there too.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25688#comment:15>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online