[tor-bugs] #29926 [Core Tor/Tor]: shellcheck: asciidoc-helper.sh issues

Tor Bug Tracker & Wiki blackhole at torproject.org
Wed Mar 27 17:17:09 UTC 2019


#29926: shellcheck: asciidoc-helper.sh issues
------------------------------+--------------------
     Reporter:  rl1987        |      Owner:  (none)
         Type:  defect        |     Status:  new
     Priority:  Medium        |  Milestone:
    Component:  Core Tor/Tor  |    Version:
     Severity:  Normal        |   Keywords:
Actual Points:                |  Parent ID:
       Points:                |   Reviewer:
      Sponsor:                |
------------------------------+--------------------
 {{{

 In doc/asciidoc-helper.sh line 22:
       TZ=UTC "$2" -d manpage -o $output $input;
                                 ^-----^ SC2086: Double quote to prevent
 globbing and word splitting.
                                         ^----^ SC2086: Double quote to
 prevent globbing and word splitting.


 In doc/asciidoc-helper.sh line 47:
     if "$2" -f manpage $input; then
                        ^----^ SC2086: Double quote to prevent globbing and
 word splitting.


 In doc/asciidoc-helper.sh line 48:
       mv $base.1 $output;
          ^---^ SC2086: Double quote to prevent globbing and word
 splitting.
                  ^-----^ SC2086: Double quote to prevent globbing and word
 splitting.

 For more information:
   https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent
 globbing ...
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29926>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list