[tor-bugs] #21377 [Core Tor/Tor]: DirAuths should expose bwauth bandwidth files

[Tor Bug Tracker & Wiki]

#21377: DirAuths should expose bwauth bandwidth files
-------------------------------------------------+-------------------------
 Reporter:  tom                                  |          Owner:  juga
     Type:  enhancement                          |         Status:
                                                 |  needs_revision
 Priority:  High                                 |      Milestone:  Tor:
                                                 |  0.4.1.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  consider-backport-after-authority-   |  Actual Points:
  test, consider-backport-after-040-stable,      |
  tor-dirauth, metrics-needs, tor-bwauth,        |
  035-removed-20180711, 040-roadmap-proposed,    |
  034-backport-maybe, 035-backport-maybe, 040    |
  -backport-maybe                                |
Parent ID:  #25925                               |         Points:
 Reviewer:  ahf                                  |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by teor):

 * status:  needs_review => needs_revision
 * keywords:
     tor-dirauth, metrics-needs, tor-bwauth, 035-removed-20180711, 040
     -roadmap-proposed
     =>
     consider-backport-after-authority-test, consider-backport-
     after-040-stable, tor-dirauth, metrics-needs, tor-bwauth,
     035-removed-20180711, 040-roadmap-proposed, 034-backport-maybe, 035
     -backport-maybe, 040-backport-maybe


Comment:

 Replying to [comment:66 juga]:
 > I was asked in
 https://github.com/torproject/tor/pull/654/files#r258582166 to use the
 #28816 refactor that was just introduced.
 > I realized that it was not backported to 0.3.5, so i don't know how to
 do in this case:
 > - should i cherry pick that in 0.3.5?
 > - should this ticket code not use #28816 patch and create a ticket to
 refactor that in 0.4?

 I will backport connection_dir_buf_add() to 0.3.4 in #29896, without the
 other refactoring.
 Then you can rebase this branch on #29896.

 I don't know if we will backport this change to 0.3.4 yet.
 It is a new feature, and we usually do not backport features.
 But it is well-contained, so it is low-risk.

 Replying to [comment:67 juga]:
 > I also don't know why with #28816 patch it seems there is no need
 anymore to flush the compression state with
 `connection_buf_add_compress("", 0, conn, 1)`.

 connection_dir_buf_add() takes a Boolean "done" parameter, and passes it
 to connection_buf_add_compress().
 Since you are only adding one item to the buffer, done should be 1.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21377#comment:68>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online