[tor-bugs] #29537 [Core Tor/Tor]: verify intptr_t round-trip through void *

Tor Bug Tracker & Wiki blackhole at torproject.org
Mon Mar 25 22:55:09 UTC 2019


#29537: verify intptr_t round-trip through void *
-------------------------------------------------+-------------------------
 Reporter:  catalyst                             |          Owner:  (none)
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.1.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  portability technical-debt nickm-    |  Actual Points:
  merge, asn-merge                               |
Parent ID:                                       |         Points:
 Reviewer:  catalyst, teor                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by teor):

 Replying to [comment:28 asn]:
 > Seems like the PR has failed because of:
 > {{{
 > ./src/test/ptr_helpers.h:No #ifndef/#define header guard pair found.
 > make[1]: *** [check-spaces] Error 1
 > }}}
 > likely the result of #29756.
 >
 > Can you please fix the offending .h file and move back to merge_ready.

 Sorry about that, the header check is new and I just merged it yesterday.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29537#comment:30>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list