[tor-bugs] #29876 [Core Tor/Tor]: get_proxy_type() may be wrong when unused PT configured

[Tor Bug Tracker & Wiki]

#29876: get_proxy_type() may be wrong when unused PT configured
------------------------------------+----------------------------------
 Reporter:  catalyst                |          Owner:  (none)
     Type:  defect                  |         Status:  new
 Priority:  Medium                  |      Milestone:  Tor: unspecified
Component:  Core Tor/Tor            |        Version:
 Severity:  Normal                  |     Resolution:
 Keywords:  technical-debt, tor-pt  |  Actual Points:
Parent ID:                          |         Points:
 Reviewer:                          |        Sponsor:  Sponsor19-can
------------------------------------+----------------------------------
Changes (by catalyst):

 * keywords:  tor-pt => technical-debt, tor-pt


Comment:

 Replying to [comment:1 mcs]:
 > I don't fully understand the issue here,
 Neither do I, which is why I filed this ticket. It might turn out to be
 not a problem in practice.
 > but note that Tor Browser does ship with several pre-configured
 `ClientTransportPlugin` lines in our bundled `torrc-defaults` file.
 Thanks, that's good to know. So the torrc-defaults file (or at least the
 `ClientTransportPlugin` lines?) remains the same regardless of Tor
 configuration changes in Tor Browser's Network Settings?

 I think that means `get_proxy_type()` always will return an incorrect
 `PROXY_PLUGGABLE` for Tor Browser, but the behavior might be functional
 anyway. I (or someone else) would likely have to look more closely at the
 code consuming `get_proxy_type()` to be sure. Even if the behavior is
 functionally correct, this might be some technical debt that we should
 eliminate.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29876#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online