[tor-bugs] #29756 [Core Tor/Tor]: Check for correct header macro guards.

Tor Bug Tracker & Wiki blackhole at torproject.org
Mon Mar 25 04:02:28 UTC 2019


#29756: Check for correct header macro guards.
--------------------------+------------------------------------
 Reporter:  nickm         |          Owner:  nickm
     Type:  defect        |         Status:  closed
 Priority:  Low           |      Milestone:  Tor: 0.4.1.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:  fixed
 Keywords:                |  Actual Points:  .1
Parent ID:                |         Points:  .1
 Reviewer:  cohosh        |        Sponsor:  Sponsor31-can
--------------------------+------------------------------------
Changes (by teor):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 The travis build failed due to #29693, it is fixed in master.

 I don't think we should backport this ticket:
 * new headers are almost always added to master
 * if they are backported, they will be merged to master first
 Also, a backport would be a nightmare, due to the refactoring over 0.3.5
 and 0.4.0.

 Merged to master.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29756#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list