[tor-bugs] #29756 [Core Tor/Tor]: Check for correct header macro guards.

Tor Bug Tracker & Wiki blackhole at torproject.org
Mon Mar 25 03:02:08 UTC 2019


#29756: Check for correct header macro guards.
--------------------------+------------------------------------
 Reporter:  nickm         |          Owner:  nickm
     Type:  defect        |         Status:  merge_ready
 Priority:  Low           |      Milestone:  Tor: 0.4.1.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:  .1
Parent ID:                |         Points:  .1
 Reviewer:  cohosh        |        Sponsor:  Sponsor31-can
--------------------------+------------------------------------
Changes (by cohosh):

 * status:  needs_review => merge_ready


Comment:

 Looks good!

 The checkSpace.pl script could use some comments stating that the new
 addition checks header files for #ifndef/#define pairs. Something along
 the lines of the {{{# Warn about}}} comments used in other parts of the
 script.

 This is a very quick fix so I'm putting this in merge_ready.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29756#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list