[tor-bugs] #29876 [Core Tor/Tor]: get_proxy_type() may be wrong when unused PT configured

[Tor Bug Tracker & Wiki]

#29876: get_proxy_type() may be wrong when unused PT configured
-------------------------------+------------------------------
     Reporter:  catalyst       |      Owner:  (none)
         Type:  defect         |     Status:  new
     Priority:  Medium         |  Milestone:  Tor: unspecified
    Component:  Core Tor/Tor   |    Version:
     Severity:  Normal         |   Keywords:  tor-pt
Actual Points:                 |  Parent ID:
       Points:                 |   Reviewer:
      Sponsor:  Sponsor19-can  |
-------------------------------+------------------------------
 Related to #28925, it looks like `get_proxy_type()` in connection.c only
 checks whether any client transport plugins are configured to determine
 whether a pluggable transport is in use. If `ClientTransportPlugin` is
 set, but no bridges are configured to use it, and a SOCKS proxy is also
 configured, maybe some code in connection.c could inappropriately attempt
 to do PT stuff when it should only be doing vanilla SOCKS proxy stuff?

 It might turn out to be ok, but it's not immediately obvious.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29876>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online