[tor-bugs] #22029 [Core Tor/Tor]: Allow ed25519 keys to be banned in the approved-routers file

[Tor Bug Tracker & Wiki]

#22029: Allow ed25519 keys to be banned in the approved-routers file
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  neel
     Type:  enhancement                          |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.1.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  034-triage-20180328,                 |  Actual Points:
  034-removed-20180328                           |
Parent ID:                                       |         Points:  1
 Reviewer:  asn                                  |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by teor):

 * status:  needs_review => needs_revision


Comment:

 Replying to [comment:28 teor]:
 > Hi, this patch contains at least one memory safety issue, and at least
 one crashing bug.
 >
 > I don't want to merge this patch unless there are unit tests for the new
 and modified functions. I want some automated checks for the issues that
 made it past review.
 >
 > I would also like someone to actually run the code on an authority. If
 you want to use chutney, the networks/bwfile and torrc_templates
 /authority-bwfile.tmpl could be copied and modified to use an
 approved_routers file.

 Replying to [comment:31 neel]:
 > I did not include a test, but he reason why a test isn't added for
 `add_ed25519_to_dir()` is because the similar RSA functions
 (`add_fingerprint_to_dir()`) were inside a `#define 0` in `test_dir.c`:
 > …
 > and wouldn't have run in the tests.

 We require unit tests for new code, so that we can find issues in new
 code.
 There were memory safety issues and crashing bugs in this code, and they
 made it past the review.
 So this code needs unit tests.
 It also needs to be tested on an authority.

 If you would like, you can also write working tests for the old RSA
 functions.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22029#comment:33>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online