[tor-bugs] #29854 [Core Tor/sbws]: Missing diagnostic keys in relay lines, but the data is in the header

[Tor Bug Tracker & Wiki]

#29854: Missing diagnostic keys in relay lines, but the data is in the header
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  juga
     Type:  defect                               |         Status:
                                                 |  assigned
 Priority:  Medium                               |      Milestone:  sbws:
                                                 |  1.1.0
Component:  Core Tor/sbws                        |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-bwauth, sbws-1.0-must-           |  Actual Points:
  moved-20181128, sbws-11x-final-                |
  removed-20190312, sbws-110-proposed, changes-  |
  version-minor                                  |
Parent ID:  #28547                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by juga):

 Replying to [ticket:29854 teor]:
 > These keys are in the bandwidth file header, but there are not any
 similar keys in the relay lines:
 > * recent_priority_list_count

 There's "relay_recent_priority_list_count":
 https://github.com/torproject/sbws/blob/0333fadc221baf17d429f55261842f9f6e09ba5b/sbws/lib/v3bwfile.py#L590.
 But i forgot to add it in the example in #29754.

 > * recent_priority_relay_count

 This would be the number of relays that were in a priority queue when this
 relay was prioritized?.
 I'm not sure it's useful.

 > * recent_measurement_attempt_count

 There's "relay_recent_measurement_attempt_count":
 https://github.com/torproject/sbws/blob/0333fadc221baf17d429f55261842f9f6e09ba5b/sbws/lib/v3bwfile.py#L590.
 But i forgot to add it in the example in #29754.

 > * recent_measurement_failure_count

 This's the one that we might be able to guess after all the others. I
 don't think it's possible to know it during the measurement, since it
 would be the case when the queued relay didn't end up in the worker thread
 `measure_relay` nor the callback `result_putter` nor the callback error
 `result_putter_err`.
 These would happen when the code reach this point:
 https://github.com/torproject/sbws/blob/0333fadc221baf17d429f55261842f9f6e09ba5b/sbws/lib/v3bwfile.py#L590
 >
 > Counting the number of times that a relay was put in the priority list
 is useful, so we can find out if a relay is not being prioritised.
 >
 > Similarly, counting the number of times that we can't measure a relay is
 also useful.
 >
 > Can we have these keys in each relay line:
 > * relay_recent_measurement_attempt_count

 It is, see above.

 > * relay_recent_measurement_failure_count

 Don't see how, see above.

 If you agree with it, this ticket can be closed.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29854#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online