[tor-bugs] #29500 [Core Tor/Tor]: Broken circuitpadding unittests on appveyor

[Tor Bug Tracker & Wiki]

#29500: Broken circuitpadding unittests on appveyor
-------------------------------------------------+-------------------------
 Reporter:  asn                                  |          Owner:
                                                 |  mikeperry
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  High                                 |      Milestone:  Tor:
                                                 |  0.4.0.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  wtf-pad, tor-relay, tor-cell,        |  Actual Points:
  padding, 041-proposed, 040-must                |
Parent ID:  #28631                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by teor):

 This bug caused the 0.4.0 changelog merge to release-0.4.0 to fail:
 {{{
 circuitpadding/circuitpadding_tokens: [forking]
   FAIL ../src/test/test_circuitpadding.c:1124: assert(mi->histogram[4]
 OP_EQ 2): 0 vs 2
   [circuitpadding_tokens FAILED]
 circuitpadding/circuitpadding_negotiation: [forking] OK
 circuitpadding/circuitpadding_wronghop: [forking] OK
 circuitpadding/circuitpadding_conditions: [forking] OK
 circuitpadding/circuitpadding_rtt: [forking]
   FAIL ../src/test/test_circuitpadding.c:323:
 assert(relay_side->padding_info[0]->last_received_time_usec OP_NE 0): 0 vs
 0
   [circuitpadding_rtt FAILED]
 }}}
 https://ci.appveyor.com/project/torproject/tor/builds/23252909/job/4ax058o810mck9xe?fullLog=true#L3043

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29500#comment:23>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online