[tor-bugs] #24546 [Core Tor/Tor]: Use tor_addr_is_v4() rather than family, or reject all v6-mapped IPv4 addresses

[Tor Bug Tracker & Wiki]

#24546: Use tor_addr_is_v4() rather than family, or reject all v6-mapped IPv4
addresses
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  neel
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  unspecified
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  unspecified
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-dirauth, ipv6,                   |  Actual Points:
  033-triage-20180320, 033-removed-20180320,     |
  035-triaged-in-20180711,                       |
  040-deferred-20190220                          |
Parent ID:                                       |         Points:  1
 Reviewer:  ahf                                  |        Sponsor:
                                                 |  SponsorV-can
-------------------------------------------------+-------------------------
Changes (by teor):

 * status:  needs_review => needs_revision
 * version:   => Tor: unspecified


Comment:

 The CI on this ticket did not pass:
 {{{
 src/core/or/policies.c: In function ‘exit_policy_remove_redundancies’:
 src/core/or/policies.c:1709:19: error: variable ‘family’ set but not used
 [-Werror=unused-but-set-variable]
        sa_family_t family;
                    ^
 cc1: all warnings being treated as errors
 make: *** [src/core/or/src_core_libtor_app_testing_a-policies.o] Error 1
 make: *** Waiting for unfinished jobs....
 }}}
 https://travis-ci.org/torproject/tor/jobs/509624393

 Please make sure that the CI passes before putting it in needs_review
 again.

 Also, the bugfix release in the changes file is the release where the bug
 was introduced, not the release where the bug was fixed. In this ticket,
 that's the release where tor_addr_is_v4() was introduced.

 Here's how you can find the release that this bug was introduced in:
 {{{
 # find the first commit that talks about tor_addr_is_v4
 $ git log --reverse -S tor_addr_is_v4 master
 commit bbbf504281
 Author: Nick Mathewson <nickm at torproject.org>
 Date:   Thu Jul 19 18:46:09 2007 +0000

      r13827 at catbus:  nickm | 2007-07-19 14:42:25 -0400
      Merge in some generic address manipulation code from croup.  Needs
 some work.
 ...
 # find the release that contains that commit
 $ git describe --contains bbbf504281
 tor-0.2.0.3-alpha~82
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24546#comment:19>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online