[tor-bugs] #29662 [Core Tor/Tor]: Introduce assert functions that allow us to printf error message

Tor Bug Tracker & Wiki blackhole at torproject.org
Fri Mar 22 02:53:39 UTC 2019


#29662: Introduce assert functions that allow us to printf error message
------------------------------------------------+--------------------------
 Reporter:  rl1987                              |          Owner:  rl1987
     Type:  enhancement                         |         Status:
                                                |  needs_revision
 Priority:  Medium                              |      Milestone:  Tor:
                                                |  0.4.1.x-final
Component:  Core Tor/Tor                        |        Version:
 Severity:  Normal                              |     Resolution:
 Keywords:  asn-merge, nickm-merge, teor-merge  |  Actual Points:
Parent ID:                                      |         Points:
 Reviewer:  ahf                                 |        Sponsor:
------------------------------------------------+--------------------------
Changes (by teor):

 * cc: nickm (added)
 * keywords:   => asn-merge, nickm-merge, teor-merge
 * status:  merge_ready => needs_revision


Comment:

 I wonder why we're using static arrays rather than tor_asprintf()?
 Are they long enough for printf-style assert messages?
 Maybe nickm knows why they have to be static arrays.

 Also, I found a grammar nitpick.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29662#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list