[tor-bugs] #29528 [Core Tor/Tor]: UndefinedBehaviorSanitizer errors should fail the unit tests

[Tor Bug Tracker & Wiki]

#29528: UndefinedBehaviorSanitizer errors should fail the unit tests
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  (none)
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.1.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-ci, tor-test, 041-proposed,      |  Actual Points:  0.2
  029-backport, 034-backport, 035-backport,      |
  040-backport                                   |
Parent ID:                                       |         Points:  2
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by teor):

 * status:  new => needs_review
 * keywords:  tor-ci, tor-test, 041-proposed =>
     tor-ci, tor-test, 041-proposed, 029-backport, 034-backport,
     035-backport, 040-backport
 * actualpoints:   => 0.2
 * milestone:  Tor: unspecified => Tor: 0.4.1.x-final


Comment:

 This ticket implements this fix, and all the child tickets.
 They can close when this ticket closes.

 Please review my branches for merging:
 * 0.2.9: https://github.com/torproject/tor/pull/812
 * 0.3.4: https://github.com/torproject/tor/pull/813

 And extra branches for testing that this fix doesn't fail CI:
 * 0.3.5: https://github.com/torproject/tor/pull/815
 * 0.4.0: https://github.com/torproject/tor/pull/816
 * master: https://github.com/torproject/tor/pull/817

 I tried to use all the current and legacy command-line arguments. I expect
 that the compilers will do something sensible if multiple arguments work:
 all we really need is the failure.

 The command-line arguments are listed here:
 https://clang.llvm.org/docs/UndefinedBehaviorSanitizer.html#usage
 https://gcc.gnu.org/onlinedocs/gcc/Instrumentation-Options.html

 The library names are listed here:
 https://stackoverflow.com/questions/29392702/missing-libclang-rt-
 san-x86-64-a-file-for-llvm-compiler-rt
 https://bugzilla.redhat.com/show_bug.cgi?id=1303766

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29528#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online