[tor-bugs] #29527 [Core Tor/Tor]: Division by zero: undefined behaviour in circuitpadding/circuitpadding_sample_distribution test

[Tor Bug Tracker & Wiki]

#29527: Division by zero: undefined behaviour in
circuitpadding/circuitpadding_sample_distribution test
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  teor
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  High                                 |      Milestone:  Tor:
                                                 |  0.4.0.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  was-merged-to-041-after-29298,       |  Actual Points:
  nickm-merge, teor-merge, regression, tor-ci,   |
  tor-test, 040-must, 040-backport               |
Parent ID:                                       |         Points:
 Reviewer:  mikeperry                            |        Sponsor:
                                                 |  Sponsor2-can
-------------------------------------------------+-------------------------
Changes (by teor):

 * keywords:
     merge-after-29298, nickm-merge, teor-merge, regression, tor-ci, tor-
     test, 040-must, 040-backport
     =>
     was-merged-to-041-after-29298, nickm-merge, teor-merge, regression,
     tor-ci, tor-test, 040-must, 040-backport
 * status:  needs_revision => needs_review


Comment:

 See my pull request:
 https://github.com/torproject/tor/pull/811

 This branch merges cleanly to master, because the cherry-picked commit
 f708055 is already in master. (So it just adds a changes file, which
 contains useful information in addition to the 0.4.1 changes file.)

 asn, this ticket had two commits in 0.4.1:
 * Fix test prob distr parameters that caused warnings. a64ccf1
 * Silence unneeded clang warns that triggered in prob distr tests. f708055
 https://github.com/torproject/tor/pull/722

 But I only backported the final one (f708055).

 a64ccf1 didn't apply cleanly to maint-0.4.0, which means the tests will
 diverge slightly. I hope that doesn't affect the stochastic failure rate
 that much in #29693.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29527#comment:30>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online