[tor-bugs] #29703 [Core Tor/Tor]: Backport test-network.sh fixes to 0.2.9

[Tor Bug Tracker & Wiki]

#29703: Backport test-network.sh fixes to 0.2.9
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  teor
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.1.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.2.9.1-alpha
 Severity:  Normal                               |     Resolution:
 Keywords:  CI, PTs 029-backport network-team-   |  Actual Points:  0.2
  roadmap-2019-Q1Q2                              |
Parent ID:  #29280                               |         Points:  0.5
 Reviewer:  nickm                                |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by teor):

 * status:  needs_review => needs_revision


Comment:

 Replying to [comment:3 nickm]:
 > None of the changes terrify me greatly, but I do have a few questions
 about the underlying rationale here:
 >
 >   * Why do we need to backport quiet mode to solve this bug?
 >   * Why do we need to backport exit status 2 to solve this bug?

 We don't, but it seemed easier to backport the same branch, rather than
 split it up.

 >   * Do we really want to be maintaining the 0.2.9 version of this script
 for the lifetime of 0.2.9?  How bad would it be to simply copy the script
 from 0.3.4 into maint-0.2.9?  (I realize that it's not our usual practice
 to consider a large backport to be better than a small one, but I think in
 this case, it might be.)

 I agree - I think the script will be easier to maintain if it matches
 0.3.4. I'll do a pull request some time today.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29703#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online