[tor-bugs] #22029 [Core Tor/Tor]: Allow ed25519 keys to be banned in the approved-routers file

[Tor Bug Tracker & Wiki]

#22029: Allow ed25519 keys to be banned in the approved-routers file
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  neel
     Type:  enhancement                          |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.1.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  034-triage-20180328,                 |  Actual Points:
  034-removed-20180328                           |
Parent ID:                                       |         Points:  1
 Reviewer:  asn                                  |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by teor):

 * status:  merge_ready => needs_revision


Comment:

 Hi, this patch contains at least one memory safety issue, and at least one
 crashing bug.

 Please fix these issues. I added comments to the pull request.

 I don't want to merge this patch unless there are unit tests for the new
 and modified functions. I want some automated checks for the issues that
 made it past review.

 I would also like someone to actually run the code on an authority. If you
 want to use chutney, the networks/bwfile and torrc_templates/authority-
 bwfile.tmpl could be copied and modified to use an approved_routers file.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22029#comment:28>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online