[tor-bugs] #29036 [Core Tor/Tor]: Coverage merge failures cause test_process_slow stderr check to fail
Tor Bug Tracker & Wiki
blackhole at torproject.org
Mon Mar 18 04:43:53 UTC 2019
#29036: Coverage merge failures cause test_process_slow stderr check to fail
-------------------------------------------------+-------------------------
Reporter: teor | Owner: ahf
Type: defect | Status:
| assigned
Priority: High | Milestone: Tor:
| 0.4.1.x-final
Component: Core Tor/Tor | Version: Tor:
| unspecified
Severity: Major | Resolution:
Keywords: 041-accepted-20190115, regression, | Actual Points:
tor-ci, 029-backport, 034-backport, |
035-backport, 040-backport |
Parent ID: | Points: 0.5
Reviewer: | Sponsor:
-------------------------------------------------+-------------------------
Changes (by teor):
* keywords: 041-accepted-20190115, regression, tor-ci =>
041-accepted-20190115, regression, tor-ci, 029-backport, 034-backport,
035-backport, 040-backport
Comment:
Replying to [comment:7 ahf]:
> I think it would make the most sense to delete the coverage files so
they don't take up space in the cache rather than deleting them from the
cache before we (maybe?) update them. It seems like these files should
never be cached, right?
It doesn't make sense to cache the files, and it's probably a bad thing:
coverage can change when unrelated modules change.
If we delete the files before caching, they'll disappear from the cache
after the first build on each branch. So the initial build, and old
branches, might still have this bug. I think that's ok?
Let's create a "clean-coverage" make target, and add it in the
"before_cache:" phase?
https://docs.travis-ci.com/user/caching/#before_cache-phase
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29036#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list