[tor-bugs] #28563 [Core Tor/sbws]: Work out how sbws can report excluded relays in the bandwidth file

Tor Bug Tracker & Wiki blackhole at torproject.org
Mon Mar 18 03:52:46 UTC 2019


#28563: Work out how sbws can report excluded relays in the bandwidth file
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  (none)
     Type:  defect                               |         Status:  new
 Priority:  Medium                               |      Milestone:  sbws:
                                                 |  1.1.0
Component:  Core Tor/sbws                        |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-bwauth, sbws-1.0-must-           |  Actual Points:
  moved-20181128, sbws-11x-final-                |
  removed-20190312, sbws-110-proposed, changes-  |
  version-minor                                  |
Parent ID:  #28547                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by teor):

 Replying to [comment:13 juga]:
 > Replying to [comment:12 teor]:
 > > I think we should do two things:
 > > 1. show all the relays in the consensus in the sbws bandwidth file
 > > 2. when sbws wants tor to exclude a relay from the vote, make tor
 ignore the bandwidths for that relay
 > >
 > > You can do whatever you need to do to the tickets to make these things
 happen.
 >
 > Just to clarify whether i understand this correctly, from
 https://trac.torproject.org/projects/tor/ticket/28158#comment:13:
 >
 > > > One thing would be to include all the "non-eligible relays" lines,
 as lines that Tor will not currently parse.
 > >
 > > Let's change the relays that are in the bandwidth file, but tor won't
 vote on them, in #28563.
 >
 > Ok, so i'll add non-eligible relays without `bw` key so Tor doesn't
 parse them.
 >
 > > > Other different thing is to report all "eligible relays", even if
 they are not the 60% of the relays in the network.
 >
 > So, from 1. above, i'll include all relays (eligible and not eligible)
 without the `bw` key so Tor doesn't parse them, when they're not the 60%.
 >
 > Correct?

 I think I know what you mean, but I am not sure. Please use shorter
 sentences?

 === Finding Every Relay ===

 Relay operators want to know about their relays.
 So we need to know what sbws thinks about every relay.
 We can find out what sbws thinks by putting some information about every
 relay in every bandwidth file.

 It doesn't matter if we are excluding the relays due to eligibility, or
 60% measured, or some other rule. We want all the relays in the file.

 There are two different ways to find every relay:
 1. all the relays which sbws has tried to test in the last 5 days
 2. all the relays in the current consensus

 I think option 1 is better, because it includes more relays. But option 2
 is also ok. You can choose the option that is easier or faster. Please
 document the option that you choose.

 === Making Tor Ignore Relays ===

 We don't want this change to change the relays that tor is voting on. So
 we want tor to ignore the new relays added by this change.

 Tor ignores lines without a "bw=" key. But Tor 0.3.5 and later log an
 "Incomplete bandwidth file" warning for every incomplete line, every time
 they parse the file. That's not ok: we can not fill up authority operators
 logs with warnings.

 Instead, you could use "bw=0 unmeasured=1 vote=0" and patch tor so that it
 ignores relay lines with "vote=0". Can you open another ticket for this
 Tor change?

 Tor versions without the patch will give more 0 votes to unmeasured
 relays, so they will get lower bandwidth values in the consensus. That's
 ok.

 We might want to vote 0 for unmeasured relays in a future sbws or tor
 version. That's why I added the "unmeasured=1" key. But it's not a change
 I want to make now, because you only have 10 paid days left. Can you open
 another ticket for this sbws change?

 Please also document the way that you make tor ignore relays.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28563#comment:14>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list