[tor-bugs] #28329 [Applications/Tor Browser]: Design TBA+Orbot configuration UI/UX

[Tor Bug Tracker & Wiki]

#28329: Design TBA+Orbot configuration UI/UX
-------------------------------------------------+-------------------------
 Reporter:  sysrqb                               |          Owner:  tbb-
                                                 |  team
     Type:  enhancement                          |         Status:
                                                 |  needs_revision
 Priority:  Very High                            |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-mobile, ux-team, TBA-a3,         |  Actual Points:
  TorBrowserTeam201903, tbb-8.5                  |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
                                                 |  Sponsor8
-------------------------------------------------+-------------------------

Comment (by gk):

 Here is what is still left over after looking at `28329_17`

 `res/drawable/tor_spinning_onion.xml` - license?

 For readability (and consistency across files) newlines between XML
 header, license, and the meat of the files would be good.

 "ViewPager containing for our bootstrapping pages" s/containing for/for
 containting/ ?

 "stop bootstrapping animation" s/stop/stop the/

 nit: "being used. There" <- one whitespace too much :) (in
 TorPreferences.java)

 "clicks on the Change link" <- missing "." at the end

 "if meek-azure if chosen" -> s/if chosen/is chosen/

 {{{
 +    // This implements TorNetworkBridgePopulateList so it can receive the
 list
 +    // of bridges asynchronously from Gecko.
 }}}
 can go
 {{{
 // Request the list of built-in bridges after the View is created
 }}}
 can go, too

 'substitute it with "meek_lite"'.  s/meek_lite/meek/

 The switch for enabling/disabling bridges itself is jumping a bit during
 the transition, probably depending on the text. I think the correct
 behavior would be that the switch stayed where it is and just the text
 "moves".

 comment:61 is still an issue.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28329#comment:71>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online