[tor-bugs] #29440 [Applications/Tor Browser]: Update about:tor when Tor Browser is updated

[Tor Bug Tracker & Wiki]

#29440: Update about:tor when Tor Browser is updated
-------------------------------------------------+-------------------------
 Reporter:  antonela                             |          Owner:  tbb-
                                                 |  team
     Type:  task                                 |         Status:  closed
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:  fixed
 Keywords:  ux-team, tbb-update,                 |  Actual Points:
  TorBrowserTeam201903R, tbb-8.5                 |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Replying to [comment:23 mcs]:
 > Replying to [comment:22 gk]:
 > > Two final questions (I think :) ):
 > >
 > > 1) What's the reason for having
 > > {{{
 > > +        m_tb_prefs.clearUserPref(kShouldNotifyPref);
 > > }}}
 > > in the Torbutton patch? What is the scenario you are worried about
 here that makes you clearing the user pref?
 >
 > We need to clear that pref so that the post-update variation of the
 about:tor page is only shown once.

 Right, I can see now why, thanks.

 > > 2) What is "tor-right" in "include in the tor-right corner" in the
 Torbutton commit message? Did you mean "upper-right"? (If so, what about
 RTL bundles)
 >
 > Apparently I have been thinking about "tor" too much. That was supposed
 to read "top-right" but in any case you are correct to question it. In an
 RTL browser it will be on the left. I fixed the commit message on the
 following branch (which contains the same two patches as before):
 >
 https://gitweb.torproject.org/user/brade/torbutton.git/log/?h=bug29440-03

 :)

 Thanks for the patches, nice work! I merged them to `tor-
 browser-60.5.1esr-8.5-1` (commits 681eefdd4234007f4984dd88abc2dfe10cbc2740
 and 0c7bd3b2fa73e8be38f5aac46cbc68d025071f05) and Torbutton's `master`
 brach (commits d45e7f502c05101660e77d430d939582728952f2 and
 82a5f8665a6b5a7f5d4c78f0a526dfa16834ec7f).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29440#comment:24>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online