[tor-bugs] #29021 [Applications/Tor Browser]: Provide a means to inform NoScript about being run in a Tor Browser context

[Tor Bug Tracker & Wiki]

#29021: Provide a means to inform NoScript about being run in a Tor Browser context
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  tbb-
                                                 |  team
     Type:  task                                 |         Status:
                                                 |  needs_review
 Priority:  Very High                            |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  noscript, TorBrowserTeam201903R,     |  Actual Points:
  tbb-8.5                                        |
Parent ID:  #27313                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by gk):

 * keywords:  noscript, TorBrowserTeam201903 => noscript,
     TorBrowserTeam201903R, tbb-8.5
 * priority:  Medium => Very High
 * status:  needs_information => needs_review
 * cc: mcs, brade (added)


Comment:

 `bug_29021`
 (https://gitweb.torproject.org/user/gk/torbutton.git/commit/?h=bug_29021&id=3187dd92b4804c20fa08e225e629c3ec94eead03)
 has a small fix implementing Giorgio's suggestion. I verified that we are
 actually sending `isTorBrowser: true` and that we still get settings from
 NoScript back (even if it does not understand it yet).

 mcs/brade: can you take a quick look at this patch? I'd like to get it
 into both the upcoming stable and alpha release. Thanks!

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29021#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online