[tor-bugs] #22132 [Core Tor/Chutney]: Chutney should avoid waiting for set times: wait for conditions instead

[Tor Bug Tracker & Wiki]

#22132: Chutney should avoid waiting for set times: wait for conditions instead
------------------------------+---------------------------
 Reporter:  teor              |          Owner:  nickm
     Type:  defect            |         Status:  reopened
 Priority:  Medium            |      Milestone:
Component:  Core Tor/Chutney  |        Version:
 Severity:  Normal            |     Resolution:
 Keywords:                    |  Actual Points:  1.1
Parent ID:  #20647            |         Points:  2
 Reviewer:                    |        Sponsor:  Sponsor19
------------------------------+---------------------------
Changes (by teor):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 I did a draft branch for #28203, and discovered that wait_for_bootstrap
 only works with tor master:

 0.2.9 through 0.3.5 say:
 {{{
 Launching chutney using Python 2.7.15
 Waiting for nodes to bootstrap...
 Bootstrap failed. Node status:
 (-100, 'no_message', 'No bootstrap messages yet.')
 (-100, 'no_message', 'No bootstrap messages yet.')
 (-100, 'no_message', 'No bootstrap messages yet.')
 (-100, 'no_message', 'No bootstrap messages yet.')
 (-100, 'no_message', 'No bootstrap messages yet.')
 (-100, 'no_message', 'No bootstrap messages yet.')
 (-100, 'no_message', 'No bootstrap messages yet.')
 (-100, 'no_message', 'No bootstrap messages yet.')
 (-100, 'no_message', 'No bootstrap messages yet.')
 (-100, 'no_message', 'No bootstrap messages yet.')
 (-100, 'no_message', 'No bootstrap messages yet.')
 (-100, 'no_message', 'No bootstrap messages yet.')
 Tor bootstrap failed, ignoring for now.
 Running 1 verify rounds...
 }}}
 https://travis-ci.org/torproject/chutney/jobs/505562952#L1368

 0.4.0 says:
 {{{
 Launching chutney using Python 2.7.15
 Waiting for nodes to bootstrap...
 Bootstrap failed. Node status:
 (100, '(done)', 'Done')
 (100, '(done)', 'Done')
 (100, '(done)', 'Done')
 (0, '(starting)', 'Starting')
 (0, '(starting)', 'Starting')
 (100, '(done)', 'Done')
 (100, '(done)', 'Done')
 (100, '(done)', 'Done')
 (100, '(done)', 'Done')
 (100, '(done)', 'Done')
 (100, '(done)', 'Done')
 (100, '(done)', 'Done')
 Tor bootstrap failed, ignoring for now.
 }}}
 https://travis-ci.org/torproject/chutney/jobs/505562955#L1367

 If all the nodes are already bootstrapping, and we don't have the right
 regexes, then we should fail when any node fails to bootstrap (#20473).
 That way, we learn if we break tor bootstrap or chutney's
 wait_for_bootstrap feature.

 If some nodes don't bootstrap on some versions, we should allow bootstrap
 failures on those versions. I guess that's another config option to test-
 network.sh.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22132#comment:20>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online