[tor-bugs] #29706 [Core Tor/Tor]: Test failure due to memory leaks in shared-random unit tests

[Tor Bug Tracker & Wiki]

#29706: Test failure due to memory leaks in shared-random unit tests
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  teor
     Type:  defect                               |         Status:
                                                 |  merge_ready
 Priority:  Very High                            |      Milestone:  Tor:
                                                 |  0.4.1.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.2.9.1-alpha
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-ci, tor-test, memory-            |  Actual Points:  0.5
  management, 029-backport-partial,              |
  034-backport, 035-backport, 040-backport       |
Parent ID:                                       |         Points:  0.5
 Reviewer:  asn                                  |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by asn):

 * status:  needs_review => merge_ready


Comment:

 LGTM! I think this new design where the state takes responsibility for the
 SRVs is cleaner indeed.

 I also think that merging the simplified fix to 029 makes sense.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29706#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online