[tor-bugs] #29060 [Core Tor/Tor]: shellcheck: test-network.sh issues

[Tor Bug Tracker & Wiki]

#29060: shellcheck: test-network.sh issues
-------------------------------------------------+-------------------------
 Reporter:  rl1987                               |          Owner:  rl1987
     Type:  defect                               |         Status:
                                                 |  merge_ready
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.1.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  technical-debt, regression,          |  Actual Points:
  041-must                                       |
Parent ID:                                       |         Points:
 Reviewer:  ahf                                  |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by teor):

 * status:  needs_review => merge_ready


Comment:

 Replying to [comment:16 rl1987]:
 > Pull request to revert bad commit:
 https://github.com/torproject/tor/pull/779

 Looks good to me.

 Let's merge soon, we need this script to work for Tor's chutney CI.

 > However we still don't want to require bash for this script.
 >
 > We could use POSIX `getopts` [0] here, but that would require us to
 downgrade `--chutney-path`, `--tor-path` and `--quiet` to single-character
 option names.

 Breaking compatibility with existing scripts and users is not ok.

 > There's also getopt(1), but that seems to be different between Linux and
 BSD-derived systems. What do you think? Any other ideas?
 >
 > [0]
 http://pubs.opengroup.org/onlinepubs/9699919799.2018edition/utilities/getopts.html

 Does sh support accessing positional arguments by reference?
 (for example: `${$i}` or the equivalent syntax.)
 If it does, we could use a for loop to iterate through the arguments?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29060#comment:18>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online