[tor-bugs] #29703 [Core Tor/Tor]: Backport test-network.sh fixes to 0.2.9

[Tor Bug Tracker & Wiki]

#29703: Backport test-network.sh fixes to 0.2.9
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  teor
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.1.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.2.9.1-alpha
 Severity:  Normal                               |     Resolution:
 Keywords:  CI, PTs 029-backport network-team-   |  Actual Points:  0.2
  roadmap-2019-Q1Q2                              |
Parent ID:  #29280                               |         Points:  0.5
 Reviewer:  nickm                                |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by teor):

 * status:  assigned => needs_review
 * reviewer:   => nickm
 * actualpoints:   => 0.2


Comment:

 To fix this issue, we need to backport the 0.3.0 test-network.sh fixes:
 * #21570 Add a quiet mode to test-network.sh
 * #21562 Use bash in src/test/test-network.sh
 * #21581 Restore support for test-network.sh on BSD and other systems
 without bash

 The cherry-picks apply cleanly to maint-0.2.9.

 I could try to remove #21570 from the backport, but I'd rather use exactly
 the same code that we tested in 0.3.0.

 The 0.2.9 pull request is:
 https://github.com/torproject/tor/pull/773

 The 0.3.4 pull request is just an ours merge to maint-0.3.4, because these
 changes were already in 0.3.0 and later:
 https://github.com/torproject/tor/pull/778

 The 0.2.9 CI merged with chutney CI from #29280 is:
 https://github.com/torproject/tor/pull/777

 It calls chutney's test-network.sh:
 {{{
 test-network.sh: $TOR_DIR not set, trying $PWD
 test-network.sh: Calling newer chutney script
 /home/travis/build/teor2345/tor/chutney/tools/test-network.sh
 test-network.sh: using CHUTNEY_DNS_CONF '/dev/null'
 test-network.sh: $TOR_DIR is a Tor 0.3.4 or earlier build directory
 }}}
 https://travis-ci.org/teor2345/tor/jobs/503853599#L2849

 Some of the jobs failed due to #29706, which is a shared random unit test
 bug.

 Assigning the review to nickm, because this backport is part of an ongoing
 design discussion on #29280.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29703#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online