[tor-bugs] #29347 [Obfuscation/meek]: Rewrite meek-http-helper as a WebExtension

[Tor Bug Tracker & Wiki]

#29347: Rewrite meek-http-helper as a WebExtension
------------------------------+------------------------------
 Reporter:  dcf               |          Owner:  dcf
     Type:  enhancement       |         Status:  needs_review
 Priority:  Medium            |      Milestone:
Component:  Obfuscation/meek  |        Version:
 Severity:  Normal            |     Resolution:
 Keywords:  webextension      |  Actual Points:
Parent ID:                    |         Points:
 Reviewer:                    |        Sponsor:
------------------------------+------------------------------

Comment (by dcf):

 Replying to [comment:13 dcf]:
 >  * As noted in comment:9, on windows we cannot simply write the host
 manifest to a well-known path. You have to set a well-known registry key
 whose value is the path to the manifest. So [https://gitweb.torproject.org
 /pluggable-transports/meek.git/diff/meek-client-
 torbrowser/windows.go?h=webextension&id=5b539a2c5f2a8474cee3dc2c2312ad365bdb1cca
 what the code does now] is write a registry key at
 `HKEY_CURRENT_USER\SOFTWARE\Mozilla\NativeMessagingHosts\meek.http.helper`.
 That works, but I don't like the fact that it leaves a permanent trace
 outside the installation directory. I'd like to know if there are any
 ideas for removing this step.

 I decided to just do a
 [https://godoc.org/golang.org/x/sys/windows/registry#DeleteKey DeleteKey]
 on the registry key before exiting, as a best-effort attempt to clean up
 the global state. It doesn't attempt to clean any farther up the path,
 i.e. an empty `HKEY_CURRENT_USER\SOFTWARE\Mozilla\NativeMessagingHosts`
 will remain if it was missing to begin with.

  * [https://gitweb.torproject.org/pluggable-
 transports/meek.git/log/?h=0.31-webextension-2 meek] 0.31-webextension-2
  * [https://gitweb.torproject.org/user/dcf/tor-browser-build.git/commit/?h
 =meek-webextension&id=6bea7004a1187f3b8cdc1b3bc31805694905ec65 tor-
 browser-build]

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29347#comment:19>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online