[tor-bugs] #29669 [Core Tor/Tor]: hs: ADD_ONION with NEW:BEST is still pinned on v2

[Tor Bug Tracker & Wiki]

#29669: hs: ADD_ONION with NEW:BEST is still pinned on v2
-------------------------+-------------------------------------------------
     Reporter:  dgoulet  |      Owner:  (none)
         Type:  defect   |     Status:  new
     Priority:  High     |  Milestone:  Tor: 0.4.1.x-final
    Component:  Core     |    Version:  Tor: 0.3.5.1-alpha
  Tor/Tor                |   Keywords:  tor-hs, tor-control, hs-v3, tor-
     Severity:  Normal   |  spec
Actual Points:           |  Parent ID:
       Points:  1        |   Reviewer:
      Sponsor:           |
-------------------------+-------------------------------------------------
 Even though the control spec says:

 {{{
   (The "NEW:BEST" option obeys the HiddenServiceVersion torrc option
 default
   value. Since 0.3.5.1-alpha, it is 3. For Tor versions before
 0.3.5.1-alpha,
   default HiddenServiceVersion is 2.)
 }}}

 ... in control.c, the `ADD_ONION` command has this condition that
 basically pins the `NEW:BEST` to v2:

 {{{
     if (!strcasecmp(key_type_rsa1024, key_blob) ||
         !strcasecmp(key_type_best, key_blob)) {
       /* "RSA1024", RSA 1024 bit, also currently "BEST" by default. */
 }}}

 Not good! `NEW:BEST` should obey the default version, not something
 hardcoded like so. This will need a spec update to mention the correct tor
 version.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29669>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online