[tor-bugs] #29597 [Obfuscation/BridgeDB]: Cleanup bridgedb-admin git repository

[Tor Bug Tracker & Wiki]

#29597: Cleanup bridgedb-admin git repository
----------------------------------+--------------------------------
 Reporter:  dgoulet               |          Owner:  dgoulet
     Type:  task                  |         Status:  needs_revision
 Priority:  Medium                |      Milestone:
Component:  Obfuscation/BridgeDB  |        Version:
 Severity:  Normal                |     Resolution:
 Keywords:                        |  Actual Points:
Parent ID:                        |         Points:
 Reviewer:  sysrqb                |        Sponsor:
----------------------------------+--------------------------------
Changes (by sysrqb):

 * status:  needs_review => needs_revision


Comment:

 `69ab4273103a9062e9bbc4e895e3afb963fda9ca`:
  - At the top of the file: "This is bring run by the bridge authority",
 "being run"? We can probably simply say "This is run by".
 `47628df6375d4de7457a8c642157a2e852f2e9f7`:
  - Does this script use any bash-isms? I'm not sure if requiring bash is
 necessary.
  - The new lines use the wrong indentation.
 {{{
 -       --exclude from-tonga-latest.tar.gz \
 -       --exclude from-bifroest-latest.tar.gz \
 +       --exclude from-${AUTHORITY_NAME}-latest.tar.gz \
         --remove-source-files \
         . \
 -
 collector at colchicifolium.torproject.org:/srv/collector.torproject.org/collector/in
 /bridge-descriptors/polyanthum/
 +  ${REMOTE_USER}@${REMOTE_SERVER}:${REMOTE_PATH} 2>&1 | \
 +  perl -lane 'print time() . ":descriptors:" . $_' >> $LOGDIR/sync-to-
 colchicifolium.log
  fi
 @@ -25,5 +38,6 @@ if test "$SYNC_ASSIGNMENTS" = "true" ; then
      rsync \
         -a \
         assignments.log* \
 -
 collector at colchicifolium.torproject.org:/srv/collector.torproject.org/collector/in
 /bridge-descriptors/polyanthum/
 +  ${REMOTE_USER}@${REMOTE_SERVER}:${REMOTE_PATH} 2>&1 | \
 +  perl -lane 'print time() . ":descriptors:" . $_' >> $LOGDIR/sync-to-
 colchicifolium.log
  fi
 }}}
 The other changes lgtm.

 `438bc4b50aeafd6b800fd9a2730bf15be4789332`:
 lgtm. I don't know if we'll want something like this in the future. We
 probably do, but this script probably doesn't work now due to other
 bridgedb changes over the last 8 years, and we'll probably want something
 more maintainable and scalable than a single python script, too.

 `5eb94dd19eaaa7b1cc470c1641332e2cf44b80f6`: lgtm
 `c00e188bdd8d130ed981741095ae0ef6e6c22b9d`: This wasn't previously
 publicly available, but I don't see the harm in publishing it. lgtm.
 `c8541173da02717ac9e788c20c3ba4c1a9f4e508`: heh. lgtm.
 `970dc485f20e710592cf12ca177ba36058264851`: lgtm.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29597#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online