[tor-bugs] #26288 [Core Tor/Tor]: prop289: Implement authenticated SENDME

[Tor Bug Tracker & Wiki]

#26288: prop289: Implement authenticated SENDME
-------------------------------------------------+-------------------------
 Reporter:  dgoulet                              |          Owner:  dgoulet
     Type:  enhancement                          |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.1.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  prop289, 035-roadmap-master, 035     |  Actual Points:
  -triaged-in-20180711, prop289-assigned-        |
  sponsor-v, 041-proposed-on-roadmap, network-   |
  team-roadmap-2019-Q1Q2, tor-spec               |
Parent ID:                                       |         Points:  21
 Reviewer:  nickm                                |        Sponsor:
                                                 |  SponsorV
-------------------------------------------------+-------------------------

Comment (by nickm):

 Woo, I've finished reviewing.  Looks nice!  I've made some suggestions on
 the branch.

 In addition to the review comments, here is something I'd like to see: I'd
 like to see a unit test that makes sure that the calculated SENDME values
 match SENDME values that are calculated by a different process, like a
 python script or something. This will help us make sure that we're
 calculating the right function over the correct portions of the correct
 cells.  (I didn't see a test like that, but I could have missed it.)  What
 do you think?

 Also, this branch needs a changes file.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26288#comment:25>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online