[tor-bugs] #29060 [Core Tor/Tor]: shellcheck: test-network.sh issues

[Tor Bug Tracker & Wiki]

#29060: shellcheck: test-network.sh issues
----------------------------+------------------------------------
 Reporter:  rl1987          |          Owner:  rl1987
     Type:  defect          |         Status:  merge_ready
 Priority:  Medium          |      Milestone:  Tor: 0.4.1.x-final
Component:  Core Tor/Tor    |        Version:
 Severity:  Normal          |     Resolution:
 Keywords:  technical-debt  |  Actual Points:
Parent ID:                  |         Points:
 Reviewer:  ahf             |        Sponsor:
----------------------------+------------------------------------
Changes (by ahf):

 * status:  needs_review => merge_ready


Comment:

 I cannot see a reason for why we saved `$@` - maybe it was to give it a
 more explicit name?

 I think the code looks good now from what I can tell. Moving to
 `merge_ready` and then let's get an additional set of eyes on it from the
 merger :-)

 Thanks for doing this work!

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29060#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online