[tor-bugs] #29500 [Core Tor/Tor]: Broken circuitpadding unittests on appveyor

Tor Bug Tracker & Wiki blackhole at torproject.org
Mon Mar 4 22:02:01 UTC 2019


#29500: Broken circuitpadding unittests on appveyor
-------------------------------------------------+-------------------------
 Reporter:  asn                                  |          Owner:  (none)
     Type:  defect                               |         Status:  new
 Priority:  High                                 |      Milestone:  Tor:
                                                 |  0.4.0.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  wtf-pad, tor-relay, tor-cell,        |  Actual Points:
  padding, 041-proposed, 040-must                |
Parent ID:  #28631                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by mikeperry):

 Ok, I changed the monotime mocking to start at 1000 usec rather than 1000
 nsec, on the wild guess that this is a precision issue on some platforms
 due to our mocking. That fix, plus the tokens test fix are at
 https://github.com/torproject/tor/pull/757

 Might as well set needs_review. I suppose there could be an argument for
 handling the case where monotime_absolute_usec() might return 0 in the
 wild, but I don't think that is actually possible there (this code only
 runs on relays upon receiving valid onionskins for circuit extension..
 lots of time should have passed since monotime_init() at that point).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29500#comment:15>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list