[tor-bugs] #31027 [Core Tor/Tor]: Coverity: circpadding: dead code in circpad_machine_remove_token

[Tor Bug Tracker & Wiki]

#31027: Coverity: circpadding: dead code in  circpad_machine_remove_token
------------------------------+--------------------------------
     Reporter:  nickm         |      Owner:  (none)
         Type:  defect        |     Status:  new
     Priority:  Medium        |  Milestone:  Tor: 0.4.2.x-final
    Component:  Core Tor/Tor  |    Version:
     Severity:  Normal        |   Keywords:  coverity
Actual Points:                |  Parent ID:
       Points:                |   Reviewer:
      Sponsor:                |
------------------------------+--------------------------------
 In `circpad_machine_remove_token()`, we check for `state==NULL` on line
 1087, and then again on line 1107.  Since state is not assigned between
 these points, the second check is dead code.

 This is CID 1447298.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31027>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online