[tor-bugs] #30732 [Applications/Tor Browser]: "Your Firefox is critically out of date" banner

[Tor Bug Tracker & Wiki]

#30732: "Your Firefox is critically out of date" banner
--------------------------------------+-----------------------------------
 Reporter:  hellomebois               |          Owner:  tbb-team
     Type:  defect                    |         Status:  needs_information
 Priority:  Medium                    |      Milestone:
Component:  Applications/Tor Browser  |        Version:
 Severity:  Normal                    |     Resolution:
 Keywords:                            |  Actual Points:
Parent ID:                            |         Points:
 Reviewer:                            |        Sponsor:
--------------------------------------+-----------------------------------

Comment (by mcs):

 Replying to [comment:11 gk]:
 > So, we set the pref to `false` in `000-tor-browser.js`. There is only
 one way this get set to `true` (apart from changing the pref manually)
 which is via https://searchfox.org/mozilla-
 esr60/source/toolkit/components/telemetry/healthreport-prefs.js#10. Which
 is only included if `MOZ_SERVICES_HEALTHREPORT` is defined
 (https://searchfox.org/mozilla-
 esr60/source/modules/libpref/greprefs.js#6). And that seems to be the
 case. So, maybe we have some race-condition here in the pref system that
 is causing this and we should make sure `MOZ_SERVICES_HEALTHREPORT` is not
 defined in the first place? (And `MOZ_TELEMETRY_REPORTING` and
 `MOZ_DATA_REPORTING` and friends) mcs/brade: what do you think?

 We agree with you that it would be better to disable more of these "phone
 home" services. The pref system race is an interesting idea, although it
 seems like we would receive more reports of this problem (unless it is
 very rare that the race finishes a certain way).


 An additional question for Steph: when you look at
 `datareporting.healthreport.uploadEnabled` via about:config, is it bold
 (user-modified)? In other words, do you have a default value of `false` or
 a default value of `true`?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30732#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online