[tor-bugs] #30237 [Applications/Tor Browser]: Tor Browser: Improve TBB UI of hidden service client authorization

[Tor Bug Tracker & Wiki]

#30237: Tor Browser: Improve TBB UI of hidden service client authorization
--------------------------------------+--------------------------------
 Reporter:  asn                       |          Owner:  tbb-team
     Type:  defect                    |         Status:  new
 Priority:  Medium                    |      Milestone:
Component:  Applications/Tor Browser  |        Version:
 Severity:  Normal                    |     Resolution:
 Keywords:  TorBrowserTeam201906      |  Actual Points:
Parent ID:  #30000                    |         Points:
 Reviewer:                            |        Sponsor:  Sponsor27-must
--------------------------------------+--------------------------------
Changes (by mcs):

 * status:  needs_information => new


Comment:

 Kathy and I pushed our "work in progress" patches for tor-browser,
 Torbutton, and Tor Launcher so that anyone who is interested can look at
 what we have so far:
 https://gitweb.torproject.org/user/brade/tor-
 browser.git/commit/?h=bug30237-01&id=d92a5bd3fd961b7b9f05383501b1bc3ed6391ecb
 https://gitweb.torproject.org/user/brade/torbutton.git/commit/?h=bug30237-01&id=a7e7992a9fa749e99bfad1a724672b6091cba1ad
 https://gitweb.torproject.org/user/brade/tor-
 launcher.git/commit/?h=bug30237-01&id=44931dac3bb51fc45aacc53c6a27e2983e84c7ac

 Here is a screenshot (yes, it will look better without the onion name
 redacted):

 [[Image(https://trac.torproject.org/projects/tor/raw-
 attachment/ticket/30237/client%20auth%20prompt%20rev1.png)]]

 Significant loose ends include:
 * Our tor-browser changes do not support localization (see the many places
 that are marked with L10n). Kathy and I would like to understand our
 localization strategy in a post-Torbutton world before we work on L10n
 support.
 * We need to insert the correct "Learn More" URL.
 * The text/copy will need some work. Some concepts are difficult to
 communicate clearly. For example, if the user enters a key of the wrong
 length or format, we currently show the somewhat cryptic validation error
 that is visible in the screenshot I posted.
 * We need artwork for the onion icon that is used within the prompt (and
 if it would be better to do so, we could remove it). As a placeholder, we
 are using a plain onion image that we downloaded from
 https://media.torproject.org/image/Onion Icon/
 * We would like Antonela to give us feedback about the UX flow and overall
 experience. For example, while the prompt is displayed we show a blank
 page behind it. Is that okay?

 Using the above patches, we created some builds for testing. We used a tor
 daemon based on David's ticket30381_042_01 branch from
 https://git.torproject.org/user/dgoulet/tor.git (which includes the work-
 in-progress patches for both #30381 and #30382). Please look at the
 README.txt file that is in the same directory as the builds for a helpful
 tip about reducing your `SocksTimeout` setting. The builds are here:

 https://people.torproject.org/~brade/testbuilds/clientauth-2019-06-27/

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30237#comment:19>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online