[tor-bugs] #31003 [Core Tor/Tor]: heap-use-after-free src/feature/nodelist/routerlist.c:704 in router_get_by_descriptor_digest

[Tor Bug Tracker & Wiki]

#31003: heap-use-after-free src/feature/nodelist/routerlist.c:704 in
router_get_by_descriptor_digest
-------------------------------------------------+-------------------------
 Reporter:  dgoulet                              |          Owner:  (none)
     Type:  defect                               |         Status:  new
 Priority:  High                                 |      Milestone:  Tor:
                                                 |  0.4.2.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-crash, tor-hs, 041-backport?     |  Actual Points:
  041-should? 041-regression?                    |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by nickm):

 * keywords:  tor-crash, tor-hs => tor-crash, tor-hs, 041-backport?
     041-should? 041-regression?
 * priority:  Medium => High


Comment:

 It looks like tor_free_all freed the object, but that it was later used.
 On the bright side tor_free_all() should only get invoked on shutdown.
 But we shouldn't get asan errors even then.

 I'm going to assume this also affects 041 until we hear otherwise

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31003#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online