[tor-bugs] #30958 [Core Tor/Tor]: Stop removing the ed25519 signature when the extra-info file is too big

[Tor Bug Tracker & Wiki]

#30958: Stop removing the ed25519 signature when the extra-info file is too big
---------------------------------------------+-----------------------------
 Reporter:  teor                             |          Owner:  teor
     Type:  defect                           |         Status:
                                             |  needs_review
 Priority:  Medium                           |      Milestone:  Tor:
                                             |  0.4.2.x-final
Component:  Core Tor/Tor                     |        Version:  Tor:
                                             |  0.2.7.2-alpha
 Severity:  Normal                           |     Resolution:
 Keywords:  tor-bridge, tor-pt, no-backport  |  Actual Points:  0.2
Parent ID:                                   |         Points:  0.1
 Reviewer:  dgoulet                          |        Sponsor:
---------------------------------------------+-----------------------------
Changes (by teor):

 * keywords:
     tor-bridge, tor-pt, 029-backport-maybe, 035-backport-maybe, 040
     -backport-maybe, 041-backport
     => tor-bridge, tor-pt, no-backport


Comment:

 I just did a spot-check on some large extra infos.
 The largest one I found was about 4.5 KB, and Tor's limit is about 48.5
 KB.
 So I think 10x is an appropriate safety margin for the next 3 years.

 (The biggest contributor to the size is the country list and client
 numbers. Each of ~250 countries can potentially take up 4 + log(client
 count) bytes. Even with a million clients per relay, that's only an extra
 2.5 KB.)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30958#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online