[tor-bugs] #30990 [Core Tor/Tor]: checkSpace.pl: clean up our list of types

[Tor Bug Tracker & Wiki]

#30990: checkSpace.pl: clean up our list of types
------------------------------+--------------------------------
     Reporter:  nickm         |      Owner:  (none)
         Type:  enhancement   |     Status:  new
     Priority:  Low           |  Milestone:  Tor: 0.4.2.x-final
    Component:  Core Tor/Tor  |    Version:
     Severity:  Normal        |   Keywords:
Actual Points:                |  Parent ID:
       Points:                |   Reviewer:
      Sponsor:                |
------------------------------+--------------------------------
 checkSpace.pl has a list of types that are returned from function
 pointers, and uses it so that we don't complain about code like this:
 {{{
   bool (*eq)(const void *a, const void *b);
 }}}

 (Without recognizing that bool is a type, practracker would think that we
 were calling a function named "bool", and complain that we had a space
 after a function call.)

 In their review for #30864, catalyst notes that the current code in
 checkSpace.pl for this is unweildy, and suggests that we use a list
 instead.  I concur.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30990>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online