[tor-bugs] #29210 [Core Tor/Tor]: Distribute control.c functionality across various modules

[Tor Bug Tracker & Wiki]

#29210: Distribute control.c functionality across various modules
--------------------------+------------------------------------
 Reporter:  nickm         |          Owner:  catalyst
     Type:  task          |         Status:  new
 Priority:  Medium        |      Milestone:  Tor: 0.4.2.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:
Parent ID:                |         Points:  10
 Reviewer:                |        Sponsor:  Sponsor31-can
--------------------------+------------------------------------

Comment (by catalyst):

 After #30889, there are no remaining uses of
 `connection_write_str_to_buf()` or `connection_printf_to_buf()` outside of
 `control_proto.c` apart from a specialized protocol error message that is
 output by `connection_control_process_inbuf()`. That error message doesn't
 conform to the `nnn Text` format in `control-spec.txt`.

 #30984 will add a key-value abstraction for control replies that should
 take care of most of the remaining controller-related uses of
 `connection_buf_add()` Maybe the async reply stuff will need a separate
 ticket.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29210#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online