[tor-bugs] #30984 [Core Tor/Tor]: Make a key-value line abstraction to output control replies

[Tor Bug Tracker & Wiki]

#30984: Make a key-value line abstraction to output control replies
-------------------------------+--------------------------------
     Reporter:  catalyst       |      Owner:  catalyst
         Type:  defect         |     Status:  assigned
     Priority:  Medium         |  Milestone:  Tor: 0.4.2.x-final
    Component:  Core Tor/Tor   |    Version:
     Severity:  Normal         |   Keywords:
Actual Points:                 |  Parent ID:  #29210
       Points:  5              |   Reviewer:
      Sponsor:  Sponsor31-can  |
-------------------------------+--------------------------------
 A few controller commands still use `connection_buf_add()` or similar low-
 level functions after constructing a list of reply lines. Almost all of
 these are key-value pairs. Create a new abstraction to output these,
 including by automatically including the correct separator character
 between the numeric code and the rest of the line.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30984>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online