[tor-bugs] #10760 [Applications/Tor Browser]: Integrate TorButton to TorBrowser core to prevent users from disabling it

[Tor Bug Tracker & Wiki]

#10760: Integrate TorButton to TorBrowser core to prevent users from disabling it
-------------------------------------------------+-------------------------
 Reporter:  Rezonansowy                          |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  High                                 |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  AffectsTails, tbb-parity, ux-team,   |  Actual Points:
  TorBrowserTeam201906, GeorgKoppen201906        |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by gk):

 * keywords:
     AffectsTails, tbb-parity, ux-team, TorBrowserTeam201906R,
     GeorgKoppen201906
     =>
     AffectsTails, tbb-parity, ux-team, TorBrowserTeam201906,
     GeorgKoppen201906
 * status:  needs_review => needs_revision


Comment:

 Replying to [comment:59 gk]:
 > 9cf79bcf222cfb1ca47f2cd6f119ac1f19b2f54d -- looks good (modulo what I
 said for 2a501682217eff74df47f45c60618b71f2a38353)
 >
 > 02c91349acdb2a493fe0089139ae765b64250a77 -- okay
 > f7238d222fe4803070f65638cd5bbd4f778a477a -- okay
 > 5426045ea02fb077b1d3c35f5c9f92c2f07facc3 -- okay

 Here come the remaining bits. The Torbutton patches seem to be okay to me.
 However, there are some smaller issues with the respective `tor-browser`
 patch (commit 8f841e5ccd0af5b1f73f5f9c74bb0fd866ba4c33).

 ce346d069afa5f1a42dfa13eb8fce2a23cfbf679
   - aboutDialog.xul -- okay; corresponding part in
   8f841e5ccd0af5b1f73f5f9c74bb0fd866ba4c33 -- please put the href entries
 back
   on the <label> line so it matches the overall style in aboutDialog.xul;
   I guess you removed the `ifdef` because we need a way to include our
 .dtd file
   while that xul file is using Fluent? Could we get a comment for that
   explaining the rationale?
   - menu-items-overlay.xul -- okay; corresponding part in
   8f841e5ccd0af5b1f73f5f9c74bb0fd866ba4c33 -- okay; i guess we could
 squash the
   patch for bug 26321 (commit 34126c910efab560ff0d6923437c50758f8dc03f)
 here?
   - menu-overlay.xul -- okay; corresponding part in
   8f841e5ccd0af5b1f73f5f9c74bb0fd866ba4c33 -- okay
   - tor-circuit-display.xul -- okay; corresponding part in
   8f841e5ccd0af5b1f73f5f9c74bb0fd866ba4c33 -- please put the label
 attributes on
   separate lines as done for other <label> elements in
 identityPanel.inc.xul and
   the original overlay; the same goes for the <html:button>k
   - torbutton-extension.xul --okay
   - torbutton.xul -- okay; corresponding part in
 8f841e5ccd0af5b1f73f5f9c74bb0fd866ba4c33 -- could you fix up the spelling
 and
   indentation of the //onLoad Hander-part? We don't need the
 stringbundleset for
   torbutton.properties anymore? I wonder why that's the case.
 Additionally, I
   guess you omitted all the toolbaricon parts as we don't want to expose
 the
   onion anymore on the toolbar? If so, then this sounds good to me.

 4dd346e2b81527785d7f8b68a5cff14972dd645c -- okay
 5b13748cdf2af2db9e829cf76e52287fb2eb2445 -- okay; corresponding part in
 8f841e5ccd0af5b1f73f5f9c74bb0fd866ba4c33 -- please add "tor" in
 components.conf after "telemetry" as the list is in alphabetical order;
 any reason to not append the `about:tor` handler to the list in
 `nsAboutRedirector.cpp` but putting it between `crashparent` and
 `crashcontent`?

 tor-browser 8f841e5ccd0af5b1f73f5f9c74bb0fd866ba4c33: `.gitmodules` change
 (and similar ones to get the browser built without having official
 branches yet) better in an additional commit after all the rebased ones as
 that is easier to discard and minimizes the risk of forgetting such items.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/10760#comment:64>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online