[tor-bugs] #30958 [Core Tor/Tor]: Stop removing the ed25519 signature when the extra-info file is too big (was: Add extra-info chunks as whole lines)

[Tor Bug Tracker & Wiki]

#30958: Stop removing the ed25519 signature when the extra-info file is too big
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  teor
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.2.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.2.7.2-alpha
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-bridge, tor-pt, 029-backport-    |  Actual Points:  0.2
  maybe, 035-backport-maybe, 040-backport-       |
  maybe, 041-backport                            |
Parent ID:                                       |         Points:  0.1
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by teor):

 * status:  assigned => needs_review
 * parent:  #30956 =>
 * cc: nickm (added)
 * actualpoints:  0.1 => 0.2
 * milestone:  Tor: 0.4.1.x-final => Tor: 0.4.2.x-final
 * keywords:  tor-bridge, tor-pt =>
     tor-bridge, tor-pt, 029-backport-maybe, 035-backport-maybe, 040
     -backport-maybe, 041-backport


Old description:

> In #30956, I discovered one extra-info line that is split across two
> chunks.
>
> If the extra-info file gets too big, tor removes one chunk at a time. So
> each chunk needs to be a complete line.

New description:

 In #30956, I discovered that the ed25519 signature extra-info line is
 split across two chunks.

 If the extra-info file gets too big, tor removes one chunk at a time. So
 each chunk needs to be a complete line.

 Edit: but in this case, we should just stop removing the signature

--

Comment:

 It turns out that we need to split these chunks, because the ed25519
 signature keyword is in the signed part of the document. So I made sure we
 don't remove any signature chunks.

 Nick, do you think we should backport this fix any further than 0.4.1?

 Please see my pull requests:
 * 0.2.9: https://github.com/torproject/tor/pull/1132

 Clean merges:
 * 0.3.5: https://github.com/torproject/tor/pull/1133
 * 0.4.0: https://github.com/torproject/tor/pull/1134
 * 0.4.1: https://github.com/torproject/tor/pull/1135
 * master: https://github.com/torproject/tor/pull/1136

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30958#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online