[tor-bugs] #30956 [Core Tor/Tor]: Publish bridge ServerTransportPlugin lines, even when ExtraInfoStatistics are off

[Tor Bug Tracker & Wiki]

#30956: Publish bridge ServerTransportPlugin lines, even when ExtraInfoStatistics
are off
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  teor
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.1.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.4.1.1-alpha
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-bridge, tor-pt, 041-backport,    |  Actual Points:  0.4
  regression, sponsor31-maybe                    |
Parent ID:  #30441                               |         Points:  0.2
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by teor):

 * status:  assigned => needs_review
 * cc: gaba (added)
 * keywords:  tor-bridge, tor-pt => tor-bridge, tor-pt, 041-backport,
     regression, sponsor31-maybe
 * actualpoints:  0.2 => 0.4


Comment:

 Gaba, this ticket can go in sponsor 31 for the refactoring, or a pluggable
 transport sponsor for the bugfix.

 See my pull request:
 * 0.4.1: https://github.com/torproject/tor/pull/1130

 I put the pluggable transport lines straight after the header. This
 conforms to the spec, because the lines can be in any order. And it makes
 the code simpler. It also makes the pluggable transport lines less likely
 to be removed if the extra info descriptor is too big (50 KB, so that's
 unlikely).

 I also did a quick refactor to satisfy practracker on master:
 * master: https://github.com/torproject/tor/pull/1131

 This makes the file bigger, but all the functions are under 100 lines.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30956#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online