[tor-bugs] #29120 [Applications/Tor Browser]: Default value of media.cache_size (0) causes some media to load extremely slowly or become unplayable
Tor Bug Tracker & Wiki
blackhole at torproject.org
Mon Jun 24 09:52:41 UTC 2019
#29120: Default value of media.cache_size (0) causes some media to load extremely
slowly or become unplayable
-------------------------------------------------+-------------------------
Reporter: QZw2aBQoPyuEVXYVlBps | Owner: tbb-
| team
Type: defect | Status: closed
Priority: High | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution: user
Keywords: tbb-disk-leak, tbb-usability- | disappeared
website, TorBrowserTeam201903R | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor:
-------------------------------------------------+-------------------------
Comment (by cypherpunks):
Great that you closed it as `user disappeared`, meaning that you couldn't
fix it. But it's a weird reason to close confirmed bugs anyway.
What the steps do you need when you have the source code? Memory limit
means that you get the error with your patch, opening no more than 4 media
instances on a 1 GB VM. The error instead of no cache, because
> I also have no idea what cypherpunks meant by that comment. The original
Mozilla code also returns nullptr on **failure**, so we're not changing
any logic in that regard. It's even documented in the function comment:
https://hg.mozilla.org/releases/mozilla-
esr60/file/256453759958ed9c2eb17a0764d2fcfd7f8e3323/dom/media/MediaCache.cpp#l152
nullptr if **initialization** failed
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29120#comment:43>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list