[tor-bugs] #30868 [Circumvention/Snowflake]: Modify client rendezvous library to remove hard-coded responses

[Tor Bug Tracker & Wiki]

#30868: Modify client rendezvous library to remove hard-coded responses
-------------------------------------+----------------------------------
 Reporter:  cohosh                   |          Owner:  (none)
     Type:  defect                   |         Status:  closed
 Priority:  Medium                   |      Milestone:  Tor: unspecified
Component:  Circumvention/Snowflake  |        Version:  Tor: unspecified
 Severity:  Normal                   |     Resolution:  not a bug
 Keywords:  ex-sponsor-19, easy      |  Actual Points:
Parent ID:  #29259                   |         Points:
 Reviewer:                           |        Sponsor:  Sponsor28
-------------------------------------+----------------------------------

Comment (by dcf):

 I thought the problem was just in some tests. I am not sure, but it looks
 like [https://gitweb.torproject.org/pluggable-
 transports/snowflake.git/tree/client/lib/lib_test.go?id=91255463c68c3ada6adc8718bf380cbd654fe9ef#n297
 this test] is checking the for the literal string "No snowflake proxies
 currently available." rather than a status code of 503.
 {{{
                 Convey("BrokerChannel.Negotiate fails with 503", func() {
                         b := NewBrokerChannel("test.broker", "",
 &MockTransport{http.StatusServiceUnavailable, []byte("\n")})
                         answer, err := b.Negotiate(fakeOffer)
                         So(err, ShouldNotBeNil)
                         So(answer, ShouldBeNil)
                         So(err.Error(), ShouldResemble, BrokerError503)
                 })
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30868#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online