[tor-bugs] #30871 [Core Tor/Tor]: circuit_mark_for_close_(): Bug: Duplicate call to circuit_mark_for_close at ../src/feature/hs/hs_service.c:3166 (first at ../src/feature/hs/hs_service.c:2385)

[Tor Bug Tracker & Wiki]

#30871: circuit_mark_for_close_(): Bug: Duplicate call to circuit_mark_for_close at
../src/feature/hs/hs_service.c:3166 (first at
../src/feature/hs/hs_service.c:2385)
-------------------------------------------------+-------------------------
 Reporter:  s7r                                  |          Owner:  dgoulet
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.2.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.4.1.2-alpha
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-hs double-mark 035-backport      |  Actual Points:
  040-backport 041-backport 041-must             |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
                                                 |  Sponsor27
-------------------------------------------------+-------------------------
Changes (by dgoulet):

 * keywords:  tor-hs 041-should 041-regression? double-mark => tor-hs
     double-mark 035-backport 040-backport 041-backport 041-must
 * status:  assigned => needs_review
 * milestone:  Tor: 0.4.1.x-final => Tor: 0.4.2.x-final


Comment:

 Issue is with `entry_guards_upgrade_waiting_circuits()` that does also
 select marked for close circuits.

 035+: https://github.com/torproject/tor/pull/1117
 041+: https://github.com/torproject/tor/pull/1118

 (yeah two PRs because practracker....)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30871#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online