[tor-bugs] #30916 [Core Tor/Tor]: assert in dimap_add_entry()

[Tor Bug Tracker & Wiki]

#30916: assert in dimap_add_entry()
------------------------------+--------------------------------
     Reporter:  dgoulet       |      Owner:  (none)
         Type:  defect        |     Status:  new
     Priority:  Medium        |  Milestone:  Tor: 0.4.2.x-final
    Component:  Core Tor/Tor  |    Version:  Tor: 0.3.5.8
     Severity:  Normal        |   Keywords:  crash
Actual Points:                |  Parent ID:
       Points:                |   Reviewer:
      Sponsor:                |
------------------------------+--------------------------------
 From tor-relays@:

 https://lists.torproject.org/pipermail/tor-relays/2019-June/017402.html

 The stack trace is:

 {{{

 Jun 18 13:33:31.000 [notice] Bootstrapped 0%: Starting
 Jun 18 13:33:32.000 [notice] Starting with guard context "default"

 ============================================================ T= 1560854012
 INTERNAL ERROR: Raw assertion failed at ../src/lib/ctime/di_ops.c:179: !
 old_val/usr/bin/tor(dump_stack_symbols_to_error_fds+0x33)[0x55a17b410943]
 /usr/bin/tor(tor_raw_assertion_failed_msg_+0x86)[0x55a17b410fd6]
 /usr/bin/tor(dimap_add_entry+0xa0)[0x55a17b411ba0]
 /usr/bin/tor(construct_ntor_key_map+0x69)[0x55a17b357969]
 /usr/bin/tor(server_onion_keys_new+0x4d)[0x55a17b39f4dd]
 /usr/bin/tor(+0x66e27)[0x55a17b287e27]
 /usr/bin/tor(threadpool_new+0x18b)[0x55a17b3b3f0b]
 /usr/bin/tor(cpu_init+0x9d)[0x55a17b28828d]
 /usr/bin/tor(run_tor_main_loop+0x136)[0x55a17b27a496]
 /usr/bin/tor(tor_run_main+0x1215)[0x55a17b27b935]
 /usr/bin/tor(tor_main+0x3a)[0x55a17b278a8a]
 /usr/bin/tor(main+0x19)[0x55a17b278609]
 /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xf1)[0x7ffb901ba2e1]
 /usr/bin/tor(_start+0x2a)[0x55a17b27865a]
 Jun 18 13:33:33.000 [notice] Tor 0.3.5.8 opening log file.
 }}}

 It appears that tor tried to add the same value in the
 `di_digest256_map_t` twice.

 Logs indicate 0.3.5.8

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30916>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online