[tor-bugs] #30733 [Core Tor/sbws]: sbws does not detect changes in descriptor bandwidth values

[Tor Bug Tracker & Wiki]

#30733: sbws does not detect changes in descriptor bandwidth values
-----------------------------------+-----------------------------------
 Reporter:  starlight              |          Owner:  juga
     Type:  defect                 |         Status:  needs_revision
 Priority:  Very High              |      Milestone:  sbws: 1.1.x-final
Component:  Core Tor/sbws          |        Version:  sbws: 1.1.0
 Severity:  Critical               |     Resolution:
 Keywords:  sbws-majority-blocker  |  Actual Points:
Parent ID:                         |         Points:
 Reviewer:                         |        Sponsor:
-----------------------------------+-----------------------------------

Comment (by juga):

 Replying to [comment:27 starlight]:
 > in longclaw data between 20190615-05 and 20190617-05 only 11% of relay
 descriptor tuples match exactly--dramatic improvement, the change appears
 to correct the issue

 This improvement might be caused by restarting sbws, not just the Fetch*
 options i added.

 I think also that when changing relaylist to keep the number of
 consensuses (417ebfa90429d3531e8a5310cf58dff4fc2ff158), the relays objects
 stop to be replaced in each consensus, but was forgotten to update also
 the descriptors attributes.

 I've restarted longclaw's sbws with this change too
 (e2ee16e1c42a243dec419b9dcc7555b0621c3e8b) and the current sbws version
 (1.1.0-dev0). Again need to wait until the relay i changed gets measured,
 so not putting this in needs_review yet.

 So maybe the descriptors where not being fetch with lot of delay, but some
 Fetch* options will ensure that they are actually recent. After a
 conversation with arma in irc, i'm just not sure that which Fetch* options
 we really need.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30733#comment:28>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online