[tor-bugs] #30858 [Core Tor/Tor]: Load geoip and geoip6 files during the unit tests

[Tor Bug Tracker & Wiki]

#30858: Load geoip and geoip6 files during the unit tests
-------------------------+-------------------------------------------------
     Reporter:  teor     |      Owner:  (none)
         Type:  defect   |     Status:  new
     Priority:  Low      |  Milestone:  Tor: unspecified
    Component:  Core     |    Version:
  Tor/Tor                |   Keywords:  technical-debt, geoip, fast-fix?,
     Severity:  Minor    |  easy?
Actual Points:           |  Parent ID:
       Points:  0.5      |   Reviewer:
      Sponsor:           |
-------------------------+-------------------------------------------------
 We don't run any tests on the contents of the geoip and geoip6 files.

 We should write a test that loads the files, and fails if they fail to
 parse, are empty, or have an unexpected number of entries. (+-25% of the
 current number of entries?)

 We might want a #define that skips the test, so that people can build and
 test without geoip. (We might eventually want geoip to be an optional
 module, but that's out of scope.)

 Maybe karsten can tell us how much the number of entries in the geoip
 files varies?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30858>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online